feat(helm): Respect helm release namespace setting #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a helm chart is rendered you can pass it a namespace. Usually a chart then adds the namespace to the namespaced resources it is rendering. This change establishes that behaviour in the fluent-operator chart. Signed-off-by: Zoltán Reegn <[email protected]>
reegnz
force-pushed
the
chart_respect_release_namespace
branch
from
f0ec12b to
737e804
Compare
benjaminhuo
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a helm chart is rendered you can pass it a namespace.
Usually a chart then adds the namespace to the namespaced resources
it is rendering.
This change establishes that behaviour in the fluent-operator chart.
What this PR does / why we need it
Helm charts tend to respect the namespace that the user passes in to the helm command.
The fluent-operator didn't render a namespace field for the namespaced resources.
Which issue(s) this PR fixes
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc